RFR: Renaming cleanup on slow path

Frederic Parain fparain at openjdk.java.net
Tue Apr 26 14:24:13 UTC 2022


On Mon, 25 Apr 2022 18:42:09 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Some renaming on the slow path. Testing loom-tiers1-3.

src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2013:

> 2011: 
> 2012:   intptr_t* from = heap_top - frame::metadata_words;
> 2013:   intptr_t* to   = frame_top - frame::metadata_words;

Some names could be more explicit.
For instance, instead of frame_top and heap_top, using stack_frame_top and heap_frame_top would be more precise, making explicit that the top value refers to a frame, which is either still on the stack, or being stored in the heap.

-------------

PR: https://git.openjdk.java.net/loom/pull/170


More information about the loom-dev mailing list