RFR: 8252388: Allocation without ResourceMark in InterpreterOopMap::resource_copy
Coleen Phillimore
coleenp at openjdk.java.net
Thu Jan 20 21:25:29 UTC 2022
On Thu, 20 Jan 2022 20:58:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> I added a ResourceMark to interpreter_frame_num_oops and kept getting confused with frame::interpreted_frame_num_oops, which I then realized is not used. So I deleted that one.
>
> I also added a ResourceMark to frame::interpreted_oops_do (the one that's used, and deleted the other) before the InterpreterOopMask definition. This necessitated using CHeap for FrameValuesOopClosure data because adding to the resource allocated _values field in the oops_interpreted_do ResourceMark got an resource mark nesting assertion.
>
> Also, I apologize for the whitespace changes. My editor removes white space at the end of lines. You'll have to remove them anyway.
>
> Ran this test: mach5 --patch-based --extra-src-dirs /scratch/cphillim/hg/jdk-loom -j loom-tier1,loom-tier2 -b linux-x64-debug'
thanks Ron, sorry for the whitespace changes.
-------------
PR: https://git.openjdk.java.net/loom/pull/85
More information about the loom-dev
mailing list