Integrated: Loom compile times minimal

[Stefan Karlsson]

On Wed, 16 Mar 2022 13:34:15 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> (Minimal version of PR #104)
> 
> It takes almost double the time to compile HotSpot in the Loom repository compared to the mainline. One source of this regression is the include of the *CollectedHeap.inline.hpp files in the *BarrierSet.inline.hpp files, needed to inline the requires_barriers call all the way down to the GC implementations.
> 
> This patch removes the inlining and calls the virtual calls instead. This recuperate most of the lost compilation speed, but not quite all (still about a 20% regression). I've verified with a small micro that this doesn't increase the freeze/thaw times. In fact, it increased the performance slightly. Comparing the generated code, I see that the inlined code had two branches and made a jump to the fast path (and not the expected slow path). With the non-inlined call there's only one branch and the fast-path is right after the check.

This pull request has now been integrated.

Changeset: 970249de
Author:    Stefan Karlsson <stefank at openjdk.org>
Committer: Alan Bateman <alanb at openjdk.org>
URL:       https://git.openjdk.java.net/loom/commit/970249de8d97f881f1d596dbfca79c0fa4e33a02
Stats:     102 lines in 13 files changed: 25 ins; 75 del; 2 mod

Loom compile times minimal

Reviewed-by: eosterlund

-------------

PR: https://git.openjdk.java.net/loom/pull/105