RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v3]
Hao Sun
haosun at openjdk.java.net
Mon Mar 21 05:15:33 UTC 2022
> As described in JBS-8282849, this build failure was introduced by commit
> bd25c94 and commit 4d27102. Adding the missing headers would fix it.
Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
Fix build error after commit 6cad807
Header "jfr/support/jfrThreadId.hpp" was removed in commit 6cad807,
leading to the following build error:
=== Output from failing command(s) repeated here ===
* For target hotspot_variant-minimal_libjvm_objs_cardGeneration.o:
In file included from ~/jdk_src/src/hotspot/share/gc/serial/defNewGeneration.hpp:30,
from ~/jdk_src/src/hotspot/share/gc/serial/defNewGeneration.inline.hpp:28,
from ~/jdk_src/src/hotspot/share/gc/shared/genOopClosures.inline.hpp:39,
from ~/jdk_src/src/hotspot/share/gc/shared/cardGeneration.cpp:32:
~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp:66:3: error: 'traceid' does not name a type
66 | traceid _thread_trace_id;
| ^~~~~~~
~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp:81:3: error: 'traceid' does not name a type
81 | traceid thread_trace_id() const { return _thread_trace_id; }
| ^~~~~~~
~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp: In constructor 'PromotionFailedInfo::PromotionFailedInfo()':
~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp:69:45: error: class 'PromotionFailedInfo' does not have any field named '_thread_trace_id'
69 | PromotionFailedInfo() : CopyFailedInfo(), _thread_trace_id(0) {}
| ^~~~~~~~~~~~~~~~
~/jdk_src/src/hotspot/share/gc/shared/copyFailedInfo.hpp: In member function 'virtual void PromotionFailedInfo::register_copy_failure(size_t)':
... (rest of output omitted)
* All command lines available in ~/build-release/make-support/failure-logs.
=== End of repeated output ===
-------------
Changes:
- all: https://git.openjdk.java.net/loom/pull/99/files
- new: https://git.openjdk.java.net/loom/pull/99/files/7be51b8f..978cfa3e
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=loom&pr=99&range=02
- incr: https://webrevs.openjdk.java.net/?repo=loom&pr=99&range=01-02
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.java.net/loom/pull/99.diff
Fetch: git fetch https://git.openjdk.java.net/loom pull/99/head:pull/99
PR: https://git.openjdk.java.net/loom/pull/99
More information about the loom-dev
mailing list