RFR: Remove Config

Coleen Phillimore coleenp at openjdk.java.net
Mon Mar 21 14:09:12 UTC 2022


On Mon, 21 Mar 2022 13:28:53 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> For you to consider.
> - Adds 1-2ns (thaw+freeze) (<0.5%)
> - Passes t1-3 (no new issues found)
> - Reduces compilation time with over 30 seconds (15-20%).
> - Loom have the same compile time as vanilla jdk/jdk.

Looks good.  This helps readability and we need convince ourselves that there's no other way to get this small bit of performance back other than these templates.

src/hotspot/share/runtime/continuation.cpp line 2613:

> 2611:     stackChunkOop chunk = _cont.tail();
> 2612:     chunk->bitmap().clear_range(chunk->bit_index_for((typename ConfigT::OopT*)start),
> 2613:                                 chunk->bit_index_for((typename ConfigT::OopT*)(start+range)));

I hate C++ template syntax.

-------------

Marked as reviewed by coleenp (Committer).

PR: https://git.openjdk.java.net/loom/pull/110


More information about the loom-dev mailing list