RFR: Small fixes - shipment one

[Coleen Phillimore]

On Tue, 22 Mar 2022 15:33:51 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/share/runtime/continuation.cpp line 180:
>> 
>>> 178: #define VERIFY_CONTINUATION(cont) verify_continuation((cont))
>>> 179: NOINLINE static bool verify_stack_chunk(oop chunk) { return InstanceStackChunkKlass::verify(chunk); }
>>> 180: #define VERIFY_STACK_CHUNK(chunk) verify_stack_chunk((chunk))
>> 
>> Thanks for fixing this.  I know Ron likes to see the asserts have a line number of the caller but there's a PR to fix this and almost all of use some debugger to see where the assert comes from in the call stack, if it's not already in the hs_err file.
>
> A better approach would be to print the line number in the assert:
> 
> InstanceStackChunkKlass::verify(chunk, __LINE__);
> The assert would be assert(good, "%u: ....", lineno, ....) ;

I guess if the callers are different, you can tell by the caller which is why this is seldom something I've noticed or thought needed fixing.

-------------

PR: https://git.openjdk.java.net/loom/pull/114