RFR: 8282849: Loom: Fix minimal debug non-PCH build failure [v4]

Hao Sun haosun at openjdk.java.net
Wed Mar 23 00:03:56 UTC 2022


On Tue, 22 Mar 2022 01:32:14 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> As described in JBS-8282849, this build failure was introduced by commit
>> bd25c94 and commit 4d27102. Adding the missing headers would fix it.
>
> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert the updates in instanceStackChunkKlass.cpp and javaClasses.inline.hpp
>   
>   The errors in file javaClasses.inline.hpp and file
>   instanceStackChunkKlass.cpp were fixed in commit
>   https://github.com/openjdk/loom/commit/970249d.
>   
>   We revert our previous updates in v1 in this patch.

As noted by `jcheck`, the update in file `copyFailedInfo.hpp` has already been done in the `fibers` branch via commit https://github.com/openjdk/loom/commit/41d4ba55c

Besides, I further checked in my local environment that the `minimal` build can pass now with the latest code in `fibers` branch.
Hence, I'd like to close this PR.
Many thanks to all the reviewers anyway.

-------------

PR: https://git.openjdk.java.net/loom/pull/99


More information about the loom-dev mailing list