<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">But won’t that be a breaking api change:<div class=""><br class=""></div><div class=""><div style="color: rgb(64, 64, 64); background-color: rgb(255, 255, 255); font-family: Menlo, Monaco, "Courier New", monospace; font-size: 12px; line-height: 18px; white-space: pre;" class=""><div class=""><span style="color: rgb(146, 205, 120);" class="">/**</span></div><div class=""><span style="color: rgb(146, 205, 120);" class=""> * Retrieves and removes the head of this queue, waiting if necessary</span></div><div class=""><span style="color: rgb(146, 205, 120);" class=""> * until an element becomes available.</span></div><div class=""><span style="color: rgb(146, 205, 120);" class=""> *</span></div><div class=""><span style="color: rgb(146, 205, 120);" class=""> * </span><span style="color: rgb(63, 151, 223);" class="">@return</span><span style="color: rgb(146, 205, 120);" class=""> the head of this queue</span></div><div class=""><span style="color: rgb(146, 205, 120);" class=""> * </span><span style="color: rgb(63, 151, 223);" class="">@throws</span><span style="color: rgb(146, 205, 120);" class=""> </span><span style="color: rgb(70, 224, 192);" class="">InterruptedException</span><span style="color: rgb(146, 205, 120);" class=""> if interrupted while waiting</span></div><div class=""><span style="color: rgb(146, 205, 120);" class=""> */</span></div><div class=""> <span style="color: rgb(70, 224, 192);" class="">E</span> <span style="color: rgb(99, 99, 36);" class="">take</span>() <span style="color: rgb(63, 151, 223);" class="">throws</span> <span style="color: rgb(70, 224, 192);" class="">InterruptedException</span>;</div></div><div><br class=""></div><div>For example, given this code:</div><div><br class=""></div><div>T timedGetElement() throws InterruptedException {</div><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);"> Timer t = Timer.start();</div><div> try {</div><div> return queue.take();</div><div> } finally {</div><div> t.stop();</div><div> }</div><div>}</div><div><br class=""></div><div>With the proposed changes, stop() may never be called - leading to potential resource leaks.</div><div><br class=""></div><div>Whereas currently the rules ensure stop() will be called unless the application hard terminates. This would essentially equating thread “death” with a hard application termination from an observability standpoint.</div><div><br class=""></div><div>You would have similar issues with any tracing/logging type frameworks.</div><div><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 3, 2024, at 9:12 AM, Ron Pressler <<a href="mailto:ron.pressler@oracle.com" class="">ron.pressler@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">On 2 Jul 2024, at 19:41, robert engels <<a href="mailto:rengels@ix.netcom.com" class="">rengels@ix.netcom.com</a>> wrote:<br class=""><br class="">Is this in an effort to allow the automatic clean-up the OP refers to?<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Not cleanup, but memory reclamation. If a thread provably can never continue, it can continue running forever (conceptually) without consuming any RAM (although you want be able to observe it). If a thread can never do anything, it behaves exactly as if the thread doesn’t exist.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class="">Wouldn’t this make the code function differently if called by a VT vs a PT? This seems like a huge problem to me and against the design of VT (and Java for that matter).<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">It would only “function” differently in the sense that observability (i.e. a thread dump) and memory consumption would be different, which are not considered functional changes by the spec.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""><blockquote type="cite" class="">On Jul 2, 2024, at 1:08 PM, Ron Pressler <<a href="mailto:ron.pressler@oracle.com" class="">ron.pressler@oracle.com</a>> wrote:<br class=""><br class="">We would eventually like to allow setting tracking option on a per-thread basis, but we need to work out a few details.<br class=""><br class=""><blockquote type="cite" class="">On 1 Jul 2024, at 20:08, Michal Domagala <<a href="mailto:outsider404@gmail.com" class="">outsider404@gmail.com</a>> wrote:<br class=""><br class="">According to <a href="https://openjdk.org/jeps/444" class="">https://openjdk.org/jeps/444</a>,<br class=""><br class="">"Unlike platform thread stacks, virtual thread stacks are not GC roots."<br class=""><br class="">But jdk.internal.vm.ThreadContainers.RootContainer.TrackingRootContainer#VTHREADS keeps (hard) references to each virtual thread. Effectively, virtual threads are GC roots.<br class=""><br class="">I described full example here:<span class="Apple-converted-space"> </span><a href="https://urldefense.com/v3/__https://stackoverflow.com/questions/78596905/why-virtual-thread-is-not-garbage-collected-when-not-reachable__;!!ACWV5N9M2RV99hQ!ISk6c21Jkzy3I92KCoA9udUUidpoMoyHTAGx1uC1gzAqH-hBQkxNMLRu6VEZxznn3M45Lbt-tlqmYwlNEQ$" class="">https://urldefense.com/v3/__https://stackoverflow.com/questions/78596905/why-virtual-thread-is-not-garbage-collected-when-not-reachable__;!!ACWV5N9M2RV99hQ!ISk6c21Jkzy3I92KCoA9udUUidpoMoyHTAGx1uC1gzAqH-hBQkxNMLRu6VEZxznn3M45Lbt-tlqmYwlNEQ$</a><span class="Apple-converted-space"> </span><br class=""><br class="">The problem was not visible since<span class="Apple-converted-space"> </span><a href="https://bugs.openjdk.org/browse/JDK-8309406" class="">https://bugs.openjdk.org/browse/JDK-8309406</a>, because before the change, VTHREADS "keep" was not enabled and i guess nobody cares memory leak.<br class=""><br class="">But after the change every JVM is affected.<br class=""><br class="">A workaround for memory leak is set jdk.trackAllThreads=false<br class=""><br class="">Best regards<br class="">Michal Domagala</blockquote></blockquote></blockquote></div></blockquote></div><br class=""></div></body></html>