hg: macosx-port/macosx-port/jdk: 124 new changesets
Henri Gomez
henri.gomez at gmail.com
Tue Apr 19 23:19:11 PDT 2011
Yes, I just see the final Compiler-llvm.gmk contains the correct line :)
Nothing to be done for CPP ?
2011/4/20 Alexander Strange <astrange at apple.com>:
> That was corrected in a later commit. hg made it difficult to squash the two across the merge commit.
>
> On Apr 20, 2011, at 1:38 AM, Henri Gomez wrote:
>
>> Looking at patch :
>>
>> -
>> - CC = $(COMPILER_PATH)llvm-gcc
>> - CPP = $(COMPILER_PATH)llvm-gcc -E
>> - CXX = $(COMPILER_PATH)llvm-g++
>> + ifeq ($(origin CC), default)
>> + CC = $(COMPILER_PATH)llvm-gcc
>> + endif
>> + CPP = $(COMPILER_PATH)llvm-gcc -E
>> + ifeq ($(origin CC), default)
>> + CXX = $(COMPILER_PATH)llvm-g++
>> + endif
>>
>> Shouldn't it be ?
>>
>> -
>> - CC = $(COMPILER_PATH)llvm-gcc
>> - CPP = $(COMPILER_PATH)llvm-gcc -E
>> - CXX = $(COMPILER_PATH)llvm-g++
>> + ifeq ($(origin CC), default)
>> + CC = $(COMPILER_PATH)llvm-gcc
>> + endif
>> + ifeq ($(origin CPP), default)
>> + CPP = $(COMPILER_PATH)llvm-gcc -E
>> + endif
>> + ifeq ($(origin CXX), default)
>> + CXX = $(COMPILER_PATH)llvm-g++
>> + endif
>>
More information about the macosx-port-dev
mailing list