webrevs.2 for macosx changes to jdk7u-osx

Weijun Wang weijun.wang at oracle.com
Thu Dec 1 06:22:46 PST 2011


Hi Michael

There is a small problem in src/share/classes/sun/security/krb5/Config.java:

  170             if (configFile == null && isMacosLionOrBetter()) {
  171                 stanzaTable = SCDynamicStoreConfig.getConfig();
  172             } else {
  173                 stanzaTable = parseStanzaTable(configFile);
  174             }

The check should probably be

     if (configFile == null && isMacOS() && isMacosLionOrBetter()) {

because isMacosLionOrBetter() simply checks os.version.

This is probably not a big issue since os.version on other platforms is 
not likely to be 10.7.1. We can also fix this later.

Thanks
Max

On 12/01/2011 09:07 PM, Michael McMahon wrote:
> Hi,
>
> This is the third version of the changes, which I would like
> to push today unless there is a major objection.
> The changes will be reviewed again before getting into
> jdk7u-dev.
>
> I have incorporated most of the comments made from
> previous reviews.
>
> Changes relative to jdk7u-osx
> ----------------------------------------
> Modified files
> http://cr.openjdk.java.net/~michaelm/7113349/3/jdk7u-osx/modified/
>
> New files
> http://cr.openjdk.java.net/~michaelm/7113349/3/jdk7u-osx/new/
>
> Changes relative to macosx-port
> --------------------------------------------
> Modified files
> http://cr.openjdk.java.net/~michaelm/7113349/3/macosx-port/modified/
>
> Thanks
> Michael.


More information about the macosx-port-dev mailing list