Code Review Request for MacOS X build change (7117748)

Vladimir Kozlov vladimir.kozlov at oracle.com
Sat Dec 3 22:58:18 PST 2011


Sorry for my ignorance (and I can't access bugster now) but why we should care about building current Hotspot with 
Apple's JDK? Is is because Macs in JPRT have only Apple's JDK?

What is _JUNK_ line for?

Why there is no separate check for -f $(SA_CLASSPATH)? Current check also requires presence of lib/modules directory.

thanks,
Vladimir

On 12/3/11 8:13 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> I have a fix that allows HSX-23 to be built on MacOS X via JPRT
> without specifying SA_APPLE_BOOT_JAVA or ALWAYS_PASS_TEST_GAMMA
> on the command line. I'm targeting this fix at RT_Baseline for
> the HSX-23-B08 snapshot.
>
> Here is the webrev URL:
>
> http://cr.openjdk.java.net/~dcubed/7117748-webrev/0/
>
> I tested this fix with the default JPRT boot JDK (JDK6 from Apple)
> and with JDK7 boot JDK (JDK7 bits from Oracle).
>
> Thanks, in advance, for any reviews.
>
> Dan
>
> P.S.
> This fix does _not_ get "gamma" working on MacOS X.
> That work is being done separately.


More information about the macosx-port-dev mailing list