Code Review Request for MacOS X build change (7117748)

[Mandy Chung]

Dan,

I'll add more details in the next reply once I go through the discussion 
in this thread.  The short answer is that you can remove the lib/modules 
check in the makefile if it helps clear the confusion.  It was the 
change I made in hotspot to prepare for the integration of jigsaw/jdk 
integration that was initially planned for jdk7 [1].

Mandy
P.S. Sorry for chiming in late.  I'm off today.

[1] http://mreinhold.org/blog/rethinking-jdk7

On 12/4/11 1:36 PM, Daniel D. Daugherty wrote:
> On 12/4/11 2:21 PM, Vladimir Kozlov wrote:
>> Dan,
>>
>> I understand that module code was there before this fix but I am 
>> still concern that if lib/modules is present the makefile will 
>> continue execution even if SA_CLASSPATH does not exits.
>
> Yes, I think that is intentional. But I will figure out who added
> the modules logic and check with them.
>
>
>> It looks like current code works for us because we don't have 
>> lib/modules in our build environment.
>
> No, the current code works when SA_APPLE_BOOT_JAVA=true is specified
> on the command line and the boot JDK is in Apple's format because the
> JDI classes are found in classes.jar. When in the boot JDK is not in
> Apple's format and SA_APPLE_BOOT_JAVA is not specified, then the code
> works because the JDI classes are found in tools.jar.
>
> As long as one of the two expected boot JDKs are provided, then the
> modules code doesn't come into play. Even if lib/modules did exist
> in either of the boot JDKs, as long as either classes.jar or tools.jar
> is found, then all is good.
>
>
>> Someone should explain why we need this modules code. Can we remove it?
>
> I'll check into why that code is there, but I think it is an
> initial stab at modules support for the future...
>
> Dan
>