Review request for MACOSX_PORT-176: AWT Splashscreen support

[Mike Swingler]

On Dec 12, 2011, at 7:19 AM, Anthony Petrov wrote:

>> Also, the QueuingApplicationDelegate should hold onto it's own NSMutableArray and real delegate as ivars, not global statics.
> 
> I agree, and I made the queue an instance variable. However, as soon as I'm trying to access an ivar from a block, I get crashed. So I left the realDelegate static.

Well, that's your first indication that something is wrong with the memory management. The ivar should be properly retained and released (converting it to an @property with an @sythesize can help with that), and the "self" should be retained by the block when it is copied to the callstack of the AppKit thread, and subsequently released when the block is finished.

Just something to think about,
Mike Swingler
Apple Inc.