hg: jdk7u/jdk7u-osx/jdk: 7123022: Fixing some Mac sanity checks
Kelly O'Hair
kelly.ohair at oracle.com
Tue Dec 20 08:25:52 PST 2011
The sanity checks have historically been used to inform the builder that they have strayed from the
systems or build dependencies used in the official builds.
And not all sanity checks are fatal errors.
On Dec 19, 2011, at 8:48 PM, Stephen Bannasch wrote:
> At 2:15 AM +0000 12/20/11, kelly.ohair at oracle.com wrote:
>> Changeset: 4868a820411b
>> Author: ohair
>> Date: 2011-12-19 18:15 -0800
>> URL: http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk/rev/4868a820411b
>>
>> 7123022: Fixing some Mac sanity checks
>> Reviewed-by: swingler
>>
>> ! make/common/shared/Defs-utils.gmk
>> ! make/common/shared/Defs-versions.gmk
>> ! make/common/shared/Platform.gmk
>> ! make/common/shared/Sanity.gmk
>
> Why is the required OS variant now 10.7.2?
Because we are supporting 10.7 and the latest 10.7 is 10.7.2. Maybe it should be 10.7.0?
>
> macosx-port has been working fine on 10.6.8 for me.
That's fine, but as far as I know, Oracle will be focusing on 10.7. So that means anything else may work fine,
but the bulk of the resources on builds and tests at Oracle will have been done with 10.7.
>
> It's one thing to only fully test on 10.7.2 but it's another thing to hard-code the build system so it only runs on 10.7.2+
This is not a hard coded thing. It's just a warning that you are may be going down a road less traveled.
I'm not even sure these sanity checks are used with openjdk builds.
>
> I'm running 10.6.8 but couldn't test the latest changes in the makefiles because the build process stopped here:
>
> -jaxp_src-url-bundle:
> [echo] Downloading from http://download.java.net/jaxp/1.4.5/jaxp145_01.zip
> [mkdir] Created dir: /Users/stephen/dev/java/src/macosx-port/build/macosx-universal/jaxp/drop/bundles
> [get] Getting: http://download.java.net/jaxp/1.4.5/jaxp145_01.zip
> [get] To: /Users/stephen/dev/java/src/macosx-port/build/macosx-universal/jaxp/drop/bundles/jaxp145_01.zip.temp
> [get] http://download.java.net/jaxp/1.4.5/jaxp145_01.zip moved to http://dlc.sun.com.edgesuite.net/jaxp/1.4.5/jaxp145_01.zip
That has nothing to do with my changes.
-kto
More information about the macosx-port-dev
mailing list