How to create a webrev from the top level directory

[Mario Torre]

Ok, to be honest with you that was a cheap suggestion :)

I tried myself to go through the code as well but decided that... well,
after all, it works fine for what we need and there are more
interesting/urgent things to do! ;)

But this gives me an idea, especially given the success of the community
warning experiment we did last month, this is a perfect candidate for a
Summer-of-code-alike program, perhaps we can make a list of little and not
so little things that are openjdk related but don't really need that deep
focus and knowledge and ask people if the feel like contributing.

Rewriting webrev in java and make it just mercurial aware could be one of
those tasks.

Cheers,
Mario

Il giorno 22-dic-2011 04.41, "Kelly O&apos;Hair" <kelly.ohair at oracle.com>
ha scritto:

>
> On Dec 20, 2011, at 8:46 PM, Mario Torre wrote:
>
> > Maybe webrev should also be updated to not need the forest extension.
>
> Yup. That's my feeling, however the last time I looked at this script I
> ran running from the room
> with a severe case of intestinal discomfort. :^(
>
> >
> > Anyway, other than for build scripts, or other similar things that
> > naturally spawn across the whole forest, it's usually better to only
> > generate webrev for the specific tree you are targeting.
>
> usually, that is true.
>
> -kto
>
> >
> > Mario
> >
> > Il giorno 21-dic-2011 02.12, "Pete Brunet" <peter.brunet at oracle.com> ha
> > scritto:
> >
> >> Thanks Kelly, I guess either this page needs to be updated to give
> >> instructions on installing Forest or on how to do a webrev without
> Forest.
> >>
> >> http://wikis.sun.com/display/OpenJDK/Mac+OS+X+Port
> >>
> >> Pete
> >>
> >> On 12/20/11 6:10 PM, Kelly O'Hair wrote:
> >>> You need the Mercurial forest extension working, and I usually use
> this:
> >>>
> >>>    webrev -f -N -o somedir
> >>>
> >>> The -N says I only want a webrev of the edited working set files.
> >>>
> >>> Yeah I know, the forest extension is a pain. Sorry.
> >>>
> >>> -kto
> >>>
> >>> On Dec 20, 2011, at 7:30 AM, Pete Brunet wrote:
> >>>
> >>>> I've been asked to create a webrev.  According to
> >>>> http://openjdk.java.net/guide/webrevHelp.html
> >>>> from the toplevel directory (macosx-port) I should execute
> >>>> ksh ./make/scripts/webrev.ksh -f
> >>>> but that produced a lot of error messages so I did
> >>>> cd jdk
> >>>> ksh ../make/scripts/webrev.ksh
> >>>> and that created my webrev
> >>>>
> >>>> What is the proper command to get it to work from the parent
> directory?
> >>>>
> >>>> Pete
> >>
>
>