Review request for MACOSX_PORT-686: Regression in drawing (Not running on AppKit thread 0...)
Anthony Petrov
anthony.petrov at oracle.com
Thu Dec 29 04:10:19 PST 2011
Hi Dmitry,
The fix looks fine. I'm just wondering, do we really have to wrap the
-dealloc into perform...:wait:YES ? Is this a requirement from
JNFJObjectWrapper?
--
best regards,
Anthony
On 12/29/11 16:25, Dmitry Cherepanov wrote:
> Hello,
>
> Please review a temporary fix for
> http://java.net/jira/browse/MACOSX_PORT-686 at
>
> http://cr.openjdk.java.net/~dcherepanov/7124263/webrev.0/
>
> The fix ensures that -drawInCGLContext: and -dealloc is called on the
> main thread (the fix is needed for the plugin and it's contributed by
> Scott Kovatch). It's still unclear why -drawInCGLContext: isn't called
> on the main thread and the change is suggested as a temporary workaround.
>
> Also, the patch includes some cleanup - it eliminates the code that
> manages JNI global ref and starts using JNFJObjectWrapper.
>
> Thanks,
> Dmitry
>
More information about the macosx-port-dev
mailing list