Objective-C files not being checked with jcheck

Scott Kovatch scott.kovatch at oracle.com
Thu Dec 29 09:50:08 PST 2011


Folks,

The 'official' copy of jcheck is not scanning .m or .mm files for whitespace violations. I use a local copy of the latest jcheck so I don't have to be on VPN all the time, and I modified the script to look at .m files as well. Two change sets just arrived with trailing whitespace.

From what I have been told about mercurial and the way jcheck works, fixing this is going to be more than a simple script change because jcheck looks at each changeset as they are applied to your local workspace.

I think I can work around this by relaxing the pretxnchangegroup.jcheck but we really should investigate this soon.

The jcheck script fix is very easy. Change line 142 to:

normext_re = re.compile(".*\.(java|c|h|cpp|hpp|m|mm)$")

-- Scott K.


----------------------------------------
Scott Kovatch
scott.kovatch at oracle.com
Santa Clara/Pleasanton, CA




More information about the macosx-port-dev mailing list