Review request for MACOSX_PORT-539: Need a java.awt.EmbeddedFrame subclass

[Scott Kovatch]

In Dmitry's new version it looks like this is now happening in CPlatformResponder. Is it necessary to track the button number during a mouse move from Java's point of view? If so you can obtain the button state with NSEvent's

+ (NSUInteger)pressedMouseButtons

instead.

-- Scott K.

On Dec 29, 2011, at 6:25 AM, Leonid Romanov wrote:

> Regarding your nsButtonToJavaButton change. Please be aware that in the case of mouse movement events, button number you get from Cocoa's NSEvent will contain uninitialized value (basically, garbage). Because of it, you can't just translate Cocoa button number into java button number as you do in CPlatformView.deliverMouseEvent
> 
> Leonid.  
> 
> On 29.12.2011, at 18:06, Dmitry Cherepanov wrote:
> 
>> Hello,
>> 
>> Please review an initial implementation for http://java.net/jira/browse/MACOSX_PORT-539 at
>> 
>> http://cr.openjdk.java.net/~dcherepanov/7124335/webrev.0/
>> 
>> Basically the fix provides a lightweight implementation of the EmbeddedFrame class (isn't backed by a NSView/NSWindow). The implementation creates an instance of CALayer and exposes it as protected CEmbeddedFrame method.
>> 
>> Please see the bug report http://java.net/jira/browse/MACOSX_PORT-539 for more details about the current version of the fix.
>> 
>> Thanks,
>> Dmitry
>> 
>