Review request for MACOSX_PORT-369: UnsupportedOperationException is thown on getLockingKeyState()
Anthony Petrov
anthony.petrov at oracle.com
Fri Dec 30 06:17:01 PST 2011
Looks good to me.
--
best regards,
Anthony
On 12/30/2011 5:52 PM, Leonid Romanov wrote:
> Hello,
> Please, review the fix for http://java.net/jira/browse/MACOSX_PORT-369
> The web rev is located at:
> http://cr.openjdk.java.net/~leonidr/7124368/webrev.00/
>
> Please, note that among the keys this method is supposed to check, only Caps Lock works as a true locking key with OS X.There is no Scroll Lock key on modern Apple keyboards, and with PC keyboard plugged in Scroll Lock is simply ignored: no LED lights up if you press it. As for Num Lock, the key located at the same position on Apple keyboards as Num Lock on PC keyboards is called Clear, doesn't lock anything and is used for entirely different purpose. Kana Lock is a mystery to me: I'm not an expert in I18N, so I've plugged in that ancient Japanese PC keyboard we have in our office, but it looks like OS X ignores Kana Lock key on this keyboard and doesn't generate any key code we can check.
>
> Thanks,
> Leonid.
>
>
>
>
>
More information about the macosx-port-dev
mailing list