Build error with latests change

[Alexander Strange]

This is not the same problem as bsd-port, where it calls ldd and then fails because it doesn't exist. I reimplemented that function using otool (noting that it always didn't find a mapfile, because we don't have mapfiles) and then built twice, once with llvm-gcc and once with Clang, and both succeeded.

I see there was no run path printed here:
>>> RUNPATH for: /Users/henri/Documents/jenkins/data/jobs/openjdk-1.7-macosx-universal/workspace/build/macosx-universal/lib/libjsig.dylib
>>> make[4]: *** [/Users/henri/Documents/jenkins/data/jobs/openjdk-1.7-macosx-universal/workspace/build/macosx-universal/lib/libjsig.dylib]
>> 

It's possible that egrep not printing anything here and returning 1 is the cause. I can't tell right now why it would pass for me.
Please try this diff, which will make binary_file_verification ignore errors:

diff --git a/make/common/shared/Defs-macosx.gmk b/make/common/shared/Defs-macosx.gmk
--- a/make/common/shared/Defs-macosx.gmk
+++ b/make/common/shared/Defs-macosx.gmk
@@ -183,5 +183,5 @@
   $(OTOOL) -L $1 && \
   $(ECHO) "RUNPATH for: $1" && \
   ( $(OTOOL) -l $1 | $(EGREP) 'path ' ) \
-)
+) || true
 endef
\ No newline at end of file

I won't be able to try it until later today.

On Mar 8, 2011, at 9:05 AM, Henri Gomez wrote:

> Did we are alone to build these sources ?
> 
> I'm more than worried to see such errors commited in HG ;(
> 
> 2011/3/8 Stephen Bannasch <stephen.bannasch at deanbrook.org>:
>> At 10:40 AM +0100 3/8/11, Henri Gomez wrote:
>>> Hi to all,
>>> 
>>> Latests change in HG broke the build :
>> 
>> ...
>> 
>>> /Users/henri/Documents/jenkins/data/jobs/openjdk-1.7-macosx-universal/workspace/build/macosx-universal/lib/libjsig.dylib:
>>>       @rpath/libjsig.dylib (compatibility version 1.0.0, current version 1.0.0)
>>>       /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
>>> version 125.2.1)
>>> RUNPATH for: /Users/henri/Documents/jenkins/data/jobs/openjdk-1.7-macosx-universal/workspace/build/macosx-universal/lib/libjsig.dylib
>>> make[4]: *** [/Users/henri/Documents/jenkins/data/jobs/openjdk-1.7-macosx-universal/workspace/build/macosx-universal/lib/libjsig.dylib]
>>> Error 1
>>> make[3]: *** [all] Error 1
>>> make[2]: *** [all] Error 1
>>> make[1]: *** [jdk-build] Error 2
>>> 
>>> Did someone got the same problem ?
>> 
>> I have the same problem looking for the RUNPATH for libjsig.dylib on bsd-port
>>