webrevs for macosx changes to jdk7u-osx

[Michael McMahon]

Phil,

Thanks for looking at this. The client code in this webrev was intended 
just as a temporary
version to get a basic system up and running. I was thinking that the 
client folks would replace
it all en-masse when they are ready. Hence, the fact that some recent 
changes might be missing,
or otherwise not of ideal quality, might not be such a serious problem. 
In any case, I'll look
at all of these points and make the changes.

Thanks,
Michael.

On 21/11/11 18:53, Phil Race wrote:
> Michael,
>
> Thanks for preparing this so we can see what the delta is. I have a 
> few comments from
> a very quick skim over this
>
> This includes a whole bunch of "isBSD" checks and the like which I 
> don't think belong in mainline.
>
> There also seems to be a bit of schizophrenia around what 
> System.getProperty("os.name");
> should return. In one place I see "Mac OS X"
> http://cr.openjdk.java.net/~michaelm/7113349/1/jdk/modified/src/share/classes/sun/print/PSPrinterJob.java.sdiff.html 
>
> here I see "Darwin"
> http://cr.openjdk.java.net/~michaelm/7113349/1/jdk/modified/src/share/classes/sun/font/FontUtilities.java.sdiff.html 
>
>
> I'm also a bit concerned by what looks like its going to remove some 
> only recently added code here :-
> http://cr.openjdk.java.net/~michaelm/7113349/1/jdk/modified/src/share/classes/sun/awt/FontConfiguration.java.sdiff.html 
>
>
> And there  "not so clean" comments and changes in shared 2D code where 
> some editing
> is justified before adding to mainline, and perhaps even examination 
> as to whether its
> the right change
> http://cr.openjdk.java.net/~michaelm/7113349/1/jdk/modified/src/share/classes/sun/print/RasterPrinterJob.java.sdiff.html 
>
>
> The changes here
> http://cr.openjdk.java.net/~michaelm/7113349/1/jdk/modified/src/share/native/sun/font/AccelGlyphCache.c.sdiff.html 
>
>
> maybe would be better to be just "#include <stdlib.h>" on all platforms.
>
>
> You'd obviously want to make sure it all builds properly on the other 
> platforms but I think
> at least the Solaris and Linux builds should be OK. In fact such a 
> change was just made in JDK 8 for this case :-
> http://cr.openjdk.java.net/~michaelm/7113349/1/jdk/modified/src/share/native/sun/awt/medialib/mlib_types.h.sdiff.html 
>
>
>
> So I don't think these changes should be pushed into mainline 
> wholesale as is.
> It needs some review by area owners and perhaps changes beyond those I 
> noticed.
>
> -phil.
>
>
> On 11/21/2011 7:46 AM, Michael McMahon wrote:
>> Hi,
>>
>> The following webrevs are an initial set of changes
>> taken from the macosx-port forest to be applied
>> to the jd7u-osx forest at: http://hg.openjdk.java.net/jdk7u/jdk7u-osx/
>> This will eventually be merged into the main jdk7u-dev forest.
>>
>> Hotspot has already integrated into this forest. This changeset includes
>> the changes (in the jdk and corba) repositories that are needed to 
>> build and run
>> openjdk on MacOSX. The AWT/client code is however taken from the BSD 
>> forest. So, the
>> native Apple AWT/client code will be integrated later. By default, 
>> the VM will run in headless
>> mode. To run with the X windows AWT, set the environment variable 
>> AWT_TOOLKIT to XToolkit.
>>
>> This is a work in progress and much remains to be done. But, it does 
>> build and run.
>> All comments welcome.
>>
>> Thanks,
>> Michael.
>>
>>
>> JDK repo
>> =====
>>
>> Modified files
>> ------------------
>> http://cr.openjdk.java.net/~michaelm/7113349/1/jdk/modified/
>>
>> New files
>> ------------
>> http://cr.openjdk.java.net/~michaelm/7113349/1/jdk/new/
>>
>> Corba repo
>> =======
>> http://cr.openjdk.java.net/~michaelm/7113349/1/corba/webrev/
>