webrevs.2 for macosx changes to jdk7u-osx

Artem Ananiev artem.ananiev at oracle.com
Tue Nov 29 08:48:33 PST 2011


On 11/29/2011 6:34 PM, Michael McMahon wrote:
> Artem,
>
> Thanks for looking at this!
>
> Actually I just realised that your comments were on the changes relative
> to macosx-port.

Ah, sorry, I didn't mention that explicitly...

> I only included that webrev for reference, in order to identify if there
> were mac related
> changes that I might have missed. So, that is why there are a number of
> files with no changes.

These webrevs are two different point of views for the same changes. I'm 
going to look through the webrev against 7u-osx tomorrow and will 
provide more feedback.

> In any case, many of your comments are still useful. I have removed the
> extraneous definitions
> from the makefiles. I also made the change to UIManager and java_props_md.c
>
> The change from "malloc.h" to stdlib.h is a simplification because
> stdlib is actually the correct
> include for malloc(), so it works the same on all platforms.
>
> awt_LoadLibrary.c is a complicated change, and I'd certainly appreciate
> your view on the webrev
> (relative to jdk7-osx) and indeed the other changes relative to jdk7-osx
> as well.
>
> Thanks
> Michael.

Thanks,

Artem


More information about the macosx-port-dev mailing list