hg: macosx-port/macosx-port/jdk: adding @summary com.apple... comments to migrated nio tests

Alexander Strange astrange at apple.com
Thu Sep 22 10:28:56 PDT 2011


On Sep 22, 2011, at 5:19 AM, Alan Bateman wrote:

> Hi,
> 
> I'm curious about the new tests that have been pushed to the macosx-port forest in recent days. Is the intention that they will ultimately be pushed upstream?
> 
> More tests are good but I'm just wondering about overlap with existing tests. I see several of the new libraries tests are in areas where they are a lot of existing tests. Also I wondering about consistency and issues like using hard coded ports, tests failing with open files, etc. So I guess my question is whether these things will be looked at.
> 
> One specific comment on the new Selector tests is that they seem to have references to a kqueue based Selector that I don't see in the repository (I might not be looking in the right replace). test/sun/nio/ch/SelProvider.java explicitly checks for it explicitly and I'm curious how it passes.

It was added in the same commit.

http://hg.openjdk.java.net/macosx-port/macosx-port/jdk/rev/cb5ebc902d33

I haven't tried that test outside macosx, so it could fail there.

> 
> Thanks,
> Alan.
> 
> 



More information about the macosx-port-dev mailing list