hg: macosx-port/macosx-port/jdk: adding @summary com.apple... comments to migrated nio tests

[Mike Swingler]

On Sep 23, 2011, at 2:37 AM, Alan Bateman wrote:

> Alexander Strange wrote:
>> :
>> It was added in the same commit.
>> 
>> http://hg.openjdk.java.net/macosx-port/macosx-port/jdk/rev/cb5ebc902d33
>> 
>> I haven't tried that test outside macosx, so it could fail there.
>>  
> Thanks, I didn't see that change-set (I was replying to a notification that changes the tests and that's what caught by eye). Adding the kqueue Selector is welcome.
> 
> So just on the tests, is the intention to push them upstream? I ran them on Linux them and several of these new tests fail for various reasons. Some of them appear to overlap with existing tests too. I guess I'm just pointing out that a bit of clean-up will be required if the intention is to push them upstream.

Yes, the intention is to push them upstream, and it will be a detailed job to pick through which ones are novel, and which ones are redundant. The Mac OS X specific tests should either be excluded if they use macosx-port specific API, or have conditional OS name checks to return early if the functionality they are testing is not available on a particular OS.

Regards,
Mike Swingler
Java Engineering
Apple Inc.