<AWT Dev> [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

[Artem Ananiev]

On 4/6/2012 8:25 PM, Sergey Bylokhov wrote:
> 05.04.2012 14:53, Artem Ananiev написал:
>> Hi, Sergey,
>>
>> On 3/28/2012 8:05 PM, Sergey Bylokhov wrote:
>>> Hi Everyone,
>>> Two issues resolved:
>>> 1) We should set caret position before the text selection.
>>
>> it's not clear why this particular change fixes the selection. Could
>> you add more comments to the bug evaluation, please?
> comment added:
> This happens because at the beginning of LWTextComponentPeer
> initialization we select text and then we call
> JTextComponent.setCaretPosition() which clears selection.

Thanks. Approved.

Artem

>> Thanks,
>>
>> Artem
>>
>>> 2) On macosx we clear selection when the test component lost its focus,
>>> so test was simplified and instructions dialog was removed (because
>>> sometimes it steal the focus from the text component)
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150100 **
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/7150100/webrev.00/
>>>
>>> --
>>> Best regards, Sergey.
>>>
>
>