RFR(M): 7147848: [macosx] com.sun.management.UnixOperatingSystem uses hardcoded dummy values

[Scott Kovatch]

Regarding Apple, Roger Hoover would be a good person to look at this, as he's spent more time in the Darwin levels of the VM. I think he's still partially attached to the OpenJDK work.

-- Scott

On Apr 10, 2012, at 8:58 AM, Daniel D. Daugherty wrote:

> Staffan,
> 
> I reviewed it and I think it looks OK. I tried looking at the code
> in MacosxOperatingSystem.c relative to the Linux version, but I think
> it is easily possible to miss something subtle here.
> 
> You might try a direct ping to Mandy Chung since M&M was her area.
> You might also try a direct ping to Mike Swingler to get an Apple
> reviewer.
> 
> Dan
> 
> 
> 
> On 4/10/12 3:30 AM, Staffan Larsen wrote:
>> Any takers for this review? (added core-libs-dev as well)
>> 
>> Thanks,
>> /Staffan
>> 
>> On 3 apr 2012, at 15:39, Staffan Larsen wrote:
>> 
>>> Please review the following fix:
>>> 
>>> webrev: http://cr.openjdk.java.net/~sla/7147848/webrev.00/ <http://cr.openjdk.java.net/%7Esla/7147848/webrev.00/>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147848
>>> 
>>> This fix implements the missing functionality in UnixOperatingSystem for Mac OS X. Any feedback on the implementation is welcome as I am not very familiar with the APIs in Mac OS X.
>>> 
>>> I have verified that the changes build on all platforms through JPRT. The correctness has been verified manually by looking in JConsole and running the tests in test/java/lang/management/OperatingSystemMXBean test/com/sun/management/OperatingSystemMXBean.
>>> 
>>> Thanks,
>>> /Staffan
>>