7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6

[Mike Swingler]

I recommended that this change be implemented for robustness against potential fluctuations in the value reported by the OS that are likely to occur.

Regards,
Mike Swingler
Apple Inc.

On Apr 19, 2012, at 9:56 AM, Alan Bateman wrote:

> 
> Jim - I see this changes lots of places to look for "OS X" in the value of the os.name property, up until now the check was to see if the os.name value starts with "Mac OS". Was this change necessary? I was following the discussion on the os.arch change but missed the discussion on os.name. I'm mostly curious to know if something was actually broken.
> 
> -Alan
> 
> 
> On 19/04/2012 16:07, coleen.phillimore at oracle.com wrote:
>> Changeset: 77b35c5c4b95
>> Author:    jmelvin
>> Date:      2012-04-16 18:09 -0400
>> URL:       http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77b35c5c4b95
>> 
>> 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6
>> Summary: On Mac OS X, align system property "os.arch" with Apple legacy JDKs.  Also, improve os.name string matching by using .contains() method instead of .startsWith(). This fix spans multiple repositories.
>> Reviewed-by: dcubed, phh, ohair, katleman
>> 
>> 
> <snip>
>