7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6

[James Melvin]

Hi Alan,

Nothing is broken... yet. The change to os.name string compares was on
the advice of Mike Swingler from Apple. They may be changing the name to
just "OS X" at some point and this change was in preparation for that
potential change. This was also pushed to 7uX earlier. The JDK 8 change
is a forward port of the same. The change also affected RE build and
promote scripts so the integration order and process was somewhat out of
the ordinary.

- Jim


On 4/19/12 12:56 PM, Alan Bateman wrote:
>
> Jim - I see this changes lots of places to look for "OS X" in the value
> of the os.name property, up until now the check was to see if the
> os.name value starts with "Mac OS". Was this change necessary? I was
> following the discussion on the os.arch change but missed the discussion
> on os.name. I'm mostly curious to know if something was actually broken.
>
> -Alan
>
>
> On 19/04/2012 16:07, coleen.phillimore at oracle.com wrote:
>> Changeset: 77b35c5c4b95
>> Author: jmelvin
>> Date: 2012-04-16 18:09 -0400
>> URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77b35c5c4b95
>>
>> 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility
>> with Apple JDK6
>> Summary: On Mac OS X, align system property "os.arch" with Apple
>> legacy JDKs. Also, improve os.name string matching by using
>> .contains() method instead of .startsWith(). This fix spans multiple
>> repositories.
>> Reviewed-by: dcubed, phh, ohair, katleman
>>
>>
> <snip>
>