[7u6] request for review: 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value

[Artem Ananiev]

Hi, Alex,

the fix looks fine. Just a minor comment:

I would use LinkedList instead of ArrayList as the type of "results" as 
this collection is mostly used to add elements: this operation is faster 
in linked lists than in array ones.

Thanks,

Artem

On 4/10/2012 9:25 PM, Alexander Potochkin wrote:
> Hello
>
> Please review the following fix:
> http://cr.openjdk.java.net/~alexp/7124328/webrev.00/
>
> for this bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124328
>
> the spec for the method
> javax.swing.JDesktopPane.getAllFrames()
>
> says
>
> * Returns all <code>JInternalFrames</code> currently displayed in the
> * desktop. Returns iconified frames as well as expanded frames.
>
> but the AquaLookAndFeel on MacOS uses a special container for the
> minimized internal frames
> and that's why the current implementation doesn't see them
>
> the proposed fix recursively looks for the internal frames
> among the JDesktopPane's children
>
> the test can be found here:
> http://java.net/jira/browse/MACOSX_PORT-557
>
> Thanks
> alexp