[8] Review request for 7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when selecting folders

[niagarasoft20-macosxportdev at yahoo.com]

I was the one who filed this bug, and think it is fine....

Just so that you know, the behavior of this dialog is different than the default OS X directory chooser behavior in that directory choosers to not allow users to also select files. Also the default select button should read [Choose] and not [Open]. So in the CFileDialog.m file the private method :


- (void)safeSaveOrLoad method should have ...


[openPanel setCanChooseFiles:NO];
[openPanel setAllowsMultipleSelection:NO]; //CAN BE YES ALSO
[openPanel setPrompt:@"Choose"]; //'Choose' should point to a localized string resource.


This then I believe would follow the OS X HIG behavior .  If the user needs to choose files they can do it with a regular native awt.FileDialog with the diretories flag unset. Thanks again Marco!

Regards,
Mike



>________________________________
> From: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
>To: "macosx-port-dev at openjdk.java.net" <macosx-port-dev at openjdk.java.net>; "awt-dev at openjdk.java.net" <awt-dev at openjdk.java.net>; Anthony Petrov <anthony.petrov at oracle.com> 
>Sent: Wednesday, August 8, 2012 12:32 PM
>Subject: [8] Review request for 7161437: [macosx] awt.FileDialog doesn't respond appropriately for mac when selecting folders
> 
>Hi Everyone,
>Please review the fix.
>We should support "apple.awt.fileDialogForDirectories"
>
>Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161437
>Webrev can be found at: http://cr.openjdk.java.net/~serb/7161437/webrev.00/
>
>Fix was contributed-by: Marco Dinacci
>Discussion here:
>http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-May/004295.html
>
>-- Best regards, Sergey.
>
>
>
>