[8] Review request for 2226249: [macosx] Java processes on Mac should not use default Apple icon

[Anthony Petrov]

Hi Leonid,

I do understand that the OS will install an icon from the bundle 
automatically if it is present, however, the following piece of code 
still looks strange since the bundleIcon is never used:

>  268         NSString* bundleIcon = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleIconFile"];
>  269         if (bundleIcon == nil) {
>  270             NSData* iconData;
>  271             iconData = [[NSData alloc] initWithBytesNoCopy: sAWTIconData length: sizeof(sAWTIconData) freeWhenDone: NO];
>  272             iconImage = [[NSImage alloc] initWithData: iconData];
>  273             [iconData release];
>  274         }

How about adding a short comment stating why it is unused in this code 
block?

Otherwise the fix looks fine.

--
best regards,
Anthony

On 8/14/2012 6:12 PM, Leonid Romanov wrote:
> Hi,
> This is a forward port of the fix that went into 7u6. 
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=2226249
> Webrev: http://cr.openjdk.java.net/~leonidr/2226249/webrev.00/
> 
> Thanks,
> Leonid.
> 
>