[8] Review request for 7186371: [macosx] Main menu shortcuts not displayed (7u6 regression)

[Sergey Bylokhov]

Does anybody has a chance to review it?
Thanks.

13.08.2012 19:26, Sergey Bylokhov wrote:
> Thanks Leonid.
>
> Does anybody has a chance to review it?
>
> 08.08.2012 10:20, Leonid Romanov wrote:
>> Looks reasonable.
>>
>> -----Original Message-----
>> From: Sergey Bylokhov [mailto:Sergey.Bylokhov at oracle.com]
>> Sent: Tuesday, August 07, 2012 3:40 PM
>> To: Leonid Romanov; Mike Swingler; awt-dev at openjdk.java.net; 
>> macosx-port-dev at openjdk.java.net
>> Subject: [8] Review request for 7186371: [macosx] Main menu shortcuts 
>> not displayed (7u6 regression)
>>
>> Hi Everyone,
>> Please review the fix.
>> When we translate calls from our swing menu components to awt peer we
>> resets information about shortcut in the setLabel().
>> This happens because of ScreenMenuItem.setAccelerator() method call
>> peers setLabel(..,..,..) directly and does not initialize
>> ScreenMenuItem.shortcut property.
>> But default implementation of ScreenMenuItem.setLabel() assumes that
>> this field(shortcut) will be initialized.
>>
>> This works on jdk6 because it does not reset shortcut if null or empty
>> shortcut is provided.
>> As a solution we can use peers methods directly in both cases.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7186371
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7186371/webrev.00
>>
>
>


-- 
Best regards, Sergey.