[7u8] Review request for 7171045 [macosx] There are no enter or exit events reported against 8b39 for MouseEventsDuringDrag.

[Alexander Scherbatiy]

Could you review the updated fix for the JDK 7u8 where the failed test 
is removed:
    http://cr.openjdk.java.net/~alexsch/7171045/webrev7.02/

On 8/28/2012 8:37 PM, Anthony Petrov wrote:
> Hi Alexander,
>
> 1. Does the 
> closed/javax/swing/plaf/basic/BasicToolBarUI/4331392/bug4331392.java 
> test (mentioned in 7154048) pass with this fix?
      Yes, the test passes. The fix reverted back changes after the 
7154048 fix.
         
http://cr.openjdk.java.net/~alexsch/7154048/webrev7.00/src/macosx/classes/sun/lwawt/LWWindowPeer.java.udiff.html
>
> 2. What is the plan for DragWindowTest.java? We should either remove 
> it with this fix, or file a CR and remove '@' from the '@run' jtreg 
> tag so that it wouldn't fail for the time being.
      I removed the failed DragWindowTest.java from the JDK 7u 
repository in the updated fix. But it still presents in the JDK 8 
repository and passes with the fixed 7154048 and 7171045 issues.

    Thanks,
    Alexandr.

>
> -- 
> best regards,
> Anthony
>
> On 8/28/2012 4:57 PM, Alexander Scherbatiy wrote:
>> Hello,
>>
>> Please review the fix for the JDK 7u8:
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171045
>> webrev: http://cr.openjdk.java.net/~alexsch/7171045/webrev7.00/
>>
>> This is a regression after the fix 7154048 [macosx] At least drag 
>> twice, the toolbar can be dragged to the left side.
>>
>> In the case where a toolbar is created under a mouse and it is 
>> dragged over the initial window the mouse enter/exit events should 
>> not be generated for the components which are under the toolbar.
>> The disabling component mouse enter/exit events generation during 
>> drag leads that it does not work in the case where a mouse is dragged 
>> over the current window.
>>
>> The full fix that checks that a current window is a topmost window 
>> under mouse requires some changes (using tracking area instead of 
>> tracking rectangle and so on) is a quite complicated and it seems 
>> that it is risky to include it to the JDK 7u8.
>>
>> Current fix just changes the condition for the component mouse 
>> enter/exit events generation to the initial state how it was before 
>> the 7154048 fix.
>>
>> This allows to generate components mouse enter/exit events, but the 
>> following test will fail:
>>   java/awt/Mouse/EnterExitEvents/DragWindowTest.java
>> However this test did not work before the 7154048 fix so it is not a 
>> regression.
>>
>>
>> Thanks,
>> Alexandr.
>>