Review request for 7124382: [macosx] Property sun.awt.enableExtraMouseButtons is always 'false'

Alexander Potochkin Alexander.Potochkin at oracle.com
Thu Feb 2 05:51:04 PST 2012


Hello Leonid
> In Cocoa, extra mouse buttons are numbered starting from 3 (0, 1, 2 are left, right and center buttons).  In Java, extra mouse buttons are numbered starting from 4 (1, 2 and 3 are left, center and right). So, in order to translate NS extra button number into Java button number we just +1 it.

Aga, I see it

The fix looks good to me

Thanks
alexp

>
>
> On 02.02.2012, at 17:30, Alexander Potochkin wrote:
>
>> Hello Leonid
>>
>> Could you comment the change in the NSEvent.nsButtonToJavaButton() method?
>>
>> Thanks
>> alexp
>>
>>> Hi,
>>> Please, review a fix for for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124382
>>> webrev: http://cr.openjdk.java.net/~leonidr/7124382/webrev.00/
>>>
>>> Thanks,
>>> Leonid.
>>>
>>>



More information about the macosx-port-dev mailing list