Review request for 7141281: [macosx] GridBagLayout baseline issue

Artem Ananiev artem.ananiev at oracle.com
Tue Feb 7 09:12:43 PST 2012


On 2/7/2012 8:48 PM, Alexander Potochkin wrote:
> Hello Artem
>>
>> On 2/6/2012 8:20 PM, Alexander Potochkin wrote:
>>> Hello
>>>
>>> Please review the following fix:
>>> http://cr.openjdk.java.net/~alexp/7141281/webrev.00/
>>>
>>> the bug's description is here:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141281
>>>
>>> With http://java.net/jira/browse/MACOSX_PORT-626
>>> JSpinner now supports setFont() method.
>>> We also need a baseline support, copied from BasicSpinnerUI.
>>
>> Does it make sense to call super.getX() methods, given that the
>> returned values are ignored anyway?
>
> Both super methods check the parameters and throw an exception if they
> are not valid

OK. Thanks for clarifying that.

Artem

> Thanks
> alexp
>
>> Thanks,
>>
>> Artem
>>
>>> Thanks
>>> alexp
>>>
>>>
>


More information about the macosx-port-dev mailing list