Review request for 7132793: [macosx] setWheelScrollEnabled action reversed

Alexander Potochkin Alexander.Potochkin at oracle.com
Mon Feb 20 06:39:38 PST 2012


Hello

Thanks for looking at it Artem

Sergey just reported that surprisingly this fix doesn't work well for 
MacOSX 10.6 GUI
when ScrollBars have arrow buttons (unlike with 10.7)

So I completely rewrote this fix, making sure it works for both OS versions.
Simultaneous supporting of horizontal and vertical scrolling events on a 
touch-pad
is a nice side effect of this approach.
(awt.ScrollPane on JDK 1.6 supports only vertical scrolling)

Here you are:

http://cr.openjdk.java.net/~alexp/7132793/webrev.01/

Thanks
alexp

>
> Looks fine to me.
>
> Thanks,
>
> Artem
>
> On 2/15/2012 9:19 PM, Alexander Potochkin wrote:
>> Hello
>>
>> Please review the following fix:
>> http://cr.openjdk.java.net/~alexp/7132793/webrev.00/
>>
>> the bug's description is here:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132793
>>
>> LWScrollPanePeer doesn't respect wheelScrollingEnabled property
>> and doesn't implement several methods that are necessary
>> to support scrolling with the mouse wheel.
>>
>> sun.awt.ScrollPaneWheelScroller.getAdjustableToScroll() works only
>> if the ScrollPane's insets are set
>>
>> Thanks
>> alexp



More information about the macosx-port-dev mailing list