Request for review 7147066: [macosx] FileDialog.getDirectory() returns incorrect directory
Anthony Petrov
anthony.petrov at oracle.com
Tue Feb 28 06:37:15 PST 2012
Looks good.
--
best regards,
Anthony
On 2/28/2012 2:45 AM, Dmitry Cherepanov wrote:
> Hello,
>
> Here's a fix for two regressions caused by the changes for the multiple
> file selection support [1] (7124337). The fix adds an additional check
> "result == NSOKButton" to avoid the exception "attempt to insert nil
> object from objects[0]". Also after the fix, the file dialog returns a
> string constructed from -[NSURL path] (without the file protocol) as it
> was before the fix for 7124337.
>
> Webrev - http://cr.openjdk.java.net/~dcherepanov/7147066/webrev/
>
> Thanks,
> Dmitry
>
> [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0e2f3e494814
More information about the macosx-port-dev
mailing list