Review request: 7123679 Update regression tests that use os.name to work on MacOSX

Alan Bateman Alan.Bateman at oracle.com
Thu Jan 5 13:29:38 PST 2012


On 05/01/2012 20:11, Kurchi Hazra wrote:
>
> :
>
> Hi Alan,
>
>
>    Thanks for the review. By method here, did you mean the 
> onSolarisOrLinux() method?
>
> The updated webrev is at 
> http://cr.openjdk.java.net/~khazra/7123679/webrev.01/
>
> I changed osName.equals("Mac OS X") to osName.startsWith("Mac OS")  to 
> make these tests valid across versions (Thanks to Sandeep for pointing 
> that out).
>
This looks much better.

Minor nit in PathOps.java where L994 should be "} else {".

In DefaultSelectorProvider.java it looks like there are now unused 
imports that can be removed.

-Alan.




More information about the macosx-port-dev mailing list