Code review request: 7127660 (macosx) *Socket Async close not working
Michael McMahon
michael.x.mcmahon at oracle.com
Mon Jan 9 08:26:26 PST 2012
On 09/01/12 16:15, Alan Bateman wrote:
> On 09/01/2012 16:03, Michael McMahon wrote:
>> Could I get the following change reviewed please?
>>
>> http://cr.openjdk.java.net/~michaelm/7127660/webrev.1/
>>
>> The asynchronous close mechanism was not being compiled for Mac OS.
>> Also, the pthread mutexes used by this code, need to be explicitly
>> initialized
>> on Mac, which was not being done previously (on Linux).
> This looks okay to me. Do you also need to changes in
> src/solaris/native/sun/nio/ch/NativeThread.c?
>
> -Alan.
Yes, that needs to be changed. But, I'd prefer to do that under a nio
specific CR along with
other changes needed for NIO.
Thanks
Michael.
More information about the macosx-port-dev
mailing list