[7u4-osx] Request for approval for 7127660 (macosx) *Socket Async close not working

[Kelly O'Hair]

You are assuming that socklen_t and int are the same size.  If socklen_t is size_t, you have a problem.

-kto

On Jan 9, 2012, at 2:20 PM, Paul Hohensee wrote:

> Exactly.
> 
> Paul
> 
> On 1/9/12 5:09 PM, Daniel D. Daugherty wrote:
>> The macro does a return so I think the code is dead...
>> 
>> Dan
>> 
>> 
>> On 1/9/12 2:56 PM, Kelly O'Hair wrote:
>>> Don't think so.
>>> 
>>> I assume this socklen is to get around the different types needed.
>>> 
>>> -kto
>>> 
>>> On Jan 9, 2012, at 1:42 PM, Paul Hohensee wrote:
>>> 
>>>> In NET_RecvFrom(), isn't the last line
>>>> 
>>>>  *fromlen = socklen;
>>>> 
>>>> dead code that really shouldn't be dead?
>>>> 
>>>> Paul
>>>> 
>>>> On 1/9/12 4:27 PM, Michael McMahon wrote:
>>>>> This is a request to push the following fix to jdk7u-osx:
>>>>> 
>>>>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127660
>>>>> 
>>>>> Webrev: http://cr.openjdk.java.net/~michaelm/7127660/webrev.1/
>>>>> 
>>>>> Reviewed by: alanb
>>>>> 
>>>>> Thanks,
>>>>> Michael.