Review request for MACOSX_PORT-539: Need a java.awt.EmbeddedFrame subclass

[Artem Ananiev]

Hi, Dmitry,

here are my comments:

1. CEmbeddedFrame and CPlatformEmbeddedFrame are probably not the best 
names. I can't suggest anything better, though.

2. Is there a reason to explicitly call addNotify() in CEF constructor? 
Will it be called automatically as a part of show()?

3. CEF.handle*Event(): please, add (responder != null) checks there to 
protect these methods from calling on invisible frames.

4. There are several (platformWindow instanceof CPlatformWindow) checks 
added. Could you comment on this, please? Do you expect anything else 
than CPlatformWindow there?

5. What is the reason of exporting the getPeer() method in the 
PlatformWindow interface?

Thanks,

Artem

On 12/29/2011 6:06 PM, Dmitry Cherepanov wrote:
> Hello,
>
> Please review an initial implementation for
> http://java.net/jira/browse/MACOSX_PORT-539 at
>
> http://cr.openjdk.java.net/~dcherepanov/7124335/webrev.0/
>
> Basically the fix provides a lightweight implementation of the
> EmbeddedFrame class (isn't backed by a NSView/NSWindow). The
> implementation creates an instance of CALayer and exposes it as
> protected CEmbeddedFrame method.
>
> Please see the bug report http://java.net/jira/browse/MACOSX_PORT-539
> for more details about the current version of the fix.
>
> Thanks,
> Dmitry
>