Review request for 7125456: [macosx] Programmatically selecting List item triggers an ItemEvent

Anthony Petrov anthony.petrov at oracle.com
Tue Jan 17 07:49:02 PST 2012


Hi Alex,

The fix looks good to me.

Optional improvement: a yet better version could use the following pattern:

setSkip(true);
try {
    // ... do whatever needed
} finally {
    setSkip(flase);
}

to ensure that the delegate won't be left in the skip-event state even 
if any exceptions happen during processing the main operation.

--
best regards,
Anthony

On 1/17/2012 2:26 PM, Alexander Potochkin wrote:
> Hello
> 
> Please review the following fix:
> http://cr.openjdk.java.net/~alexp/7125456/webrev.00/
> 
> the bug's description is here:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125456
> 
> Thanks
> alexp
> 


More information about the macosx-port-dev mailing list