Review request for 7125456: [macosx] Programmatically selecting List item triggers an ItemEvent

[Anthony Petrov]

On 1/17/2012 8:30 PM, Alexander Potochkin wrote:
>> Optional improvement: a yet better version could use the following 
>> pattern:
>>
>> setSkip(true);
>> try {
>>    // ... do whatever needed
>> } finally {
>>    setSkip(flase);
>> }
>>
>> to ensure that the delegate won't be left in the skip-event state even 
>> if any exceptions happen during processing the main operation.
> 
> Using that pattern was my first idea
> 
> but I decided to keep it simple since the delegate is 100% owned by the AWT
> and we don't ever expect setSelectedIndex() to throw any exceptions

That's OK. Thanks for clarifying the reasoning.

--
best regards,
Anthony


> 
> Thanks
> alexp
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 1/17/2012 2:26 PM, Alexander Potochkin wrote:
>>> Hello
>>>
>>> Please review the following fix:
>>> http://cr.openjdk.java.net/~alexp/7125456/webrev.00/
>>>
>>> the bug's description is here:
>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125456
>>>
>>> Thanks
>>> alexp
>>>
>