Request for review: 7124524 - OutOfMemory exception after (or even before) some 2500 creations of LWWindowPeer

[Sergey Bylokhov]

17.01.2012 19:59, Anthony Petrov пишет:
> Hi Sergey,
>
> The fix looks good. Just one question: in 
> LWWindowPeer.destroyBuffers() you're removing a call to 
> replaceSurfaceData(). Are you sure that this is OK?
It is OK at least for current replaceSurfaceData implementation.
>
> -- 
> best regards,
> Anthony
>
> On 1/17/2012 5:02 PM, Sergey Bylokhov wrote:
>> Hi Everyone,
>> This is a fix for 4 memory leaks.
>> 1. LWWindowPeer does not destroy backbuffer in disposeImpl().
>> 2. LWToolkit stores unused links to Peer.
>> 3. Local references were not deleted in the AWTWindow.m, but 
>> according JNFJObjectWrapper.jObjectWithEnv documentation "returns a 
>> new local-ref, must be released with DeleteLocalRef".
>> 4. OGLContext in some cases can cache CGLSurfaceData in this case our 
>> LWWindowPeer was not collected.
>>
>> Bug: http://monaco.us.oracle.com/detail.jsf?cr=7124524
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7124524/webrev.00/
>>


-- 
Best regards, Sergey.