Review request for 7125456: [macosx] Programmatically selecting List item triggers an ItemEvent
Alexander Potochkin
Alexander.Potochkin at oracle.com
Tue Jan 17 09:56:27 PST 2012
Hello Sergey
> Yes. I overlooked lock in the sendEventToDelegate.
> The fix looks good to me.
Thanks!
alexp
>
>>
>> Do you mean any other scenarios?
>>
>> Thanks
>> alexp
>>
>>> Probably isSkipStateChangedEvent() should use getDelegateLock()?
>>>
>>> 182 public boolean isSkipStateChangedEvent() {
>>> 183 return skipStateChangedEvent;
>>> 184 }
>>> I mean that we setskipStateChangedEvent to false under delegateLock
>>> on main thread
>>> getDelegate().setSkipStateChangedEvent(false);
>>>
>>> but later we can read it on EDT without lock?
>>>
>>> public void valueChanged(final ListSelectionEvent e) {
>>> 192 if (!e.getValueIsAdjusting()&& !isSkipStateChangedEvent()) {
>>>
>>>
>>>> Thanks
>>>> alexp
>>>>
>>>
>>>
>>
>
>
More information about the macosx-port-dev
mailing list