[jdk7u-osx] Review: 7130948 Kerberos and JGSS JCK tests failing	[macosx]
    Sean Mullan 
    sean.mullan at oracle.com
       
    Wed Jan 18 11:08:38 PST 2012
    
    
  
On 01/18/2012 05:55 AM, Michael McMahon wrote:
> Could I get the following change reviewed please?
>
> The code should be throwing an IOException which can be handled
> by the immediate caller, rather than higher up the stack as a KrbException.
>
> http://cr.openjdk.java.net/~michaelm/7130948/webrev.1/
Looks fine, assuming sun.security.krb5.Config() is the only caller of 
this API - I didn't check. Also the syntax using parens around the new 
statement is obscure and doesn't seem to add anything:
   throw(new IOException("Could not load configuration from 
SCDynamicStore"));
I'd suggest just:
   throw new IOException("Could not load configuration from 
SCDynamicStore");
--Sean
    
    
More information about the macosx-port-dev
mailing list