Code Review Request: 7126993: JCK test api/java_util/jar/Jarfile jarFile0129 failing [macosx]

[Paul Hohensee]

If this change needs to be make, we should make the same
change in os_bsd.cpp.  The original value of O_DELETE in
os_bsd.cpp was 0x10000 and hasn't been changed since.

Paul

On 1/19/12 2:18 PM, Alan Bateman wrote:
> On 19/01/2012 18:56, Kurchi Hazra wrote:
>>
>> Hi,
>>
>> JCK tests api/java_util/jar/Jarfile and api/java_util/zip/ZipFile 
>> were both failing
>> on Mac because the OPEN_DELETE flag sets the JVM_O_DELETE flag in 
>> native code, and the
>> value of JVM_O_DELETE was changed from 0x10000 to0x10000000 for Mac OS.
>> The JVM_O_DELETE flag is only used in 
>> src/share/native/java/util/zip/ZipFile.c
>> and hence this change should be safe.
>>
>>
>> Bug :  http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7126993
>>
>> Webrev : http://cr.openjdk.java.net/~khazra/7126993/webrev.00/
> At some point we need to change the zip and other code so that it's 
> not using the JVM_ functions (not needed anymore). I checked 
> os_bsd.cpp and O_DELETE is defined as 0x10000 so this is the value 
> that JVM_O_DELETE needs to have in jvm_md.d. I don't know why it was 
> changed to 0x10000000 but it must have had a corresponding change in 
> HotSpot at one point.
>
> -Alan.