Review request for 7124393: [macosx] JCheckBox in JTable: checkbox doesn't alaways respond to the first mouse click

Anthony Petrov anthony.petrov at oracle.com
Tue Jan 24 04:08:31 PST 2012


Hi Alex,

I'm OK with realSync() calls, but unsure about the stopCellEditing() 
call. Indeed, using a Swing method should produce correct results. 
However, I think that this regression test is supposed to emulate user's 
actions, not Swing calls, isn't it? If so, we should either find a 
cross-platform events that finish editing and use Robot to emulate them, 
or use the "os.name" property and synthesize different user actions on 
different platforms.

Please correct me if my assumption is wrong.

--
best regards,
Anthony

On 1/23/2012 9:33 PM, Alexander Potochkin wrote:
> Hello
> 
> Please review the following fix:
> http://cr.openjdk.java.net/~alexp/7124393/webrev.00/
> 
> the bug's description is here:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124393
> 
> The bug is in the test, F2 doesn't stop editing on MacOS,
> we should not use the keyboard to commit the data
> 
> the test is also updated
> to access the Swing methods on the Event Dispatching Thread only
> 
> Thanks
> alexp


More information about the macosx-port-dev mailing list