Review request for 7129825 - [macosx] Native activation is not changed when focusing other frame's owned window

Anton V. Tarasov anton.tarasov at oracle.com
Tue Jan 24 07:23:14 PST 2012


Hello,

Please review a fix for 7129825.

webrev: http://cr.openjdk.java.net/~ant/7129825/webrev.0/

The fix contains the following changes:

1. When a simple window requests focus its owner is properly activated.

2. The code that requests focus on a window from LWWindowPeer
initial mouse handler is removed. It duplicates the logic implemented
by LWWindowPeer.handleEvent(). Additionally, a window requests focus
when its unfocusable component is clicked, or its empty spot is clicked.
In this case KeyboardFocusManager sets focus on the window's default
component.

3. The nativeIsApplicationActive() method is moved to LWToolkit.

4. Two native methods are changed to be called synchronously
(performOnMainThreadWaiting:YES) as they are called from EDT.

5. Some minor changes.

Tested with test/java/awt/Focus/* against regressions.

Thanks,
Anton.




More information about the macosx-port-dev mailing list