Request for review 7124224: [macosx] Port's controls are improperly ordered

Alexander Strange astrange at apple.com
Tue Jan 24 21:46:41 PST 2012


Looks ok to me.

On Jan 24, 2012, at 4:11 AM, Alex Menkov wrote:

> publicly accessible webrev:
> http://cr.openjdk.java.net/~amenkov/7124224/webrev.00/
> 
> regards
> Alex
> 
> On 24.01.2012 06:24, Alexander Strange wrote:
>> 
>> On Jan 23, 2012, at 3:53 AM, Alex Menkov wrote:
>> 
>>> Hi all,
>>> 
>>> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7124224
>>> webrev: http://javaweb.us.oracle.com/jcg/fx-webrevs/7124224/2/
>>> 
>>> summary of the changes:
>>> - updated the case when AudioDevice has several AudioStreams;
>>> - implemented "virtual" master/mute/balance controls;
>>> - implemented configuration detection (test for control validity);
>>> - control hierarchy was updated to be consistent with other platforms;
>>> - fixed memory leaks.
>>> 
>>> Also 2 .c files was removed (issue of macosx-port=>jdk7u-osx integration).
>> 
>> Could you post this webrev somewhere publicly accessible?
>> 
>>> 
>>> regards
>>> Alex
>> 
>> 



More information about the macosx-port-dev mailing list